Conversation
|
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
commit: |
ErKeLost
commented
Apr 15, 2025
| import { plugin, type Options } from './core' | ||
| import type { JsPlugin, PluginLoadHookParam } from '@farmfe/core' | ||
|
|
||
| const createFarmVuePlugins = (options?: Options): JsPlugin[] => { |
Member
Author
There was a problem hiding this comment.
@sxzz hi The farm plugin is ready. There are still some type issues. We'll wait for the farm to be continuously optimized later.
Since the farm does not load other types of files by default, it is necessary to wrap it with a plugin in advance to ensure normal operation without affecting other frameworks.
Member
Author
|
@sxzz hi ，can this PR be merged and a version released first? Then I'll continue to complete the remaining tasks and the entire e2e for the Vue project of Farm. |
sxzz
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi @sxzz sorry to bother you
This pr is temporarily put in draft. Currently, it is planned to mainly support farm version
2.0. The node implementation between version2.0and version1.xis very different, so I want to wait until 2.0 is fully prepared to merge this pr. In the end, farm's goal should be purely to support farm's plugin rather than adapting to the vite form. In the future, farm should deviate from vite to reduce the impact on dependenciesCurrently, farm has three plans for the idea of vue ecology （The compilation farm team for vue-jsx is under development）
unplugin-vuesupports farm in 2.0unplugin-vue-fervidthis project has been shelved for a while, and I will implement this plugin immediately. The test at that time unplugin-vue-fervid performance was about 10 to 20 times faster than the current cache of the vue compiler. The next step is to use this plugin to speed up the compilation of native vue to support other frameworks such as vite rspack and more@farmfe/plugin-vuesupports farm-native vue compilation plugin, which will improve the performance of about 5 to 10 times thanunplugin-vue-fervidin pure rust compilation